Color of legend doesnt fit the plot

Dear all,

I know this question was asked thousand times before. But none of the solutions are working for me. I have a loop to import several files. Afterwards I do some calculations and want to plot them (for all the files in one plot). Therefore I use following code:

directory_name=uigetdir('','Ordner mit Messungen auswählen'); 
[nur_file_name,pfad]=uigetfile({'*.csv','csv-files (*.csv)';'*.*','all Files'},...
    'Die csv-Files der Proben oeffnen (probe_001.csv=',[directory_name '/'], 'Multiselect', 'on'); 
nur_file_name=cellstr(nur_file_name);
nur_file_name=sort(nur_file_name);
filename=strcat(pfad,nur_file_name); 
anzahl_files=size(filename,2); 

for xy=1:anzahl_files
    fid_in=fopen(char(filename(xy)),'r'); 
    
    %Calculations...
    
%Plot Sr ratio for all files:

[NumRows1 NumCols1]=size(Ratio);
figure(1)
title('Proben 87Sr/86Sr');
xlabel('Partikel');
ylabel('87Sr/86Sr');
for p=1:anzahl_files
   h(p)= scatter(1:NumRows1, Ratio(:,1));
    legendtext{p} = filename_s(1,p);
    hold on
end
legend(h, legendtext)

end

I am sorry to ask this again. But I dont find my mistake. It plots perfectly, the probleme is just that the colours are not matching. I appreciate any help.

Answer 1

[Image Analyst]

Why are you plotting the same data (the first column of Ratio) every iteration? If you do that, all the markers are on top of each other so that only the last set will show up. Did you mean to scatter different columns of Ratio like this:

h(p)= scatter(1:NumRows1, Ratio(:, p));

[Tatjana Mü]

Because every file I import give me another ratio array. The plot is part of a bigger loop, which starts with this line:

for xy=1:anzahl_files
    fid_in=fopen(char(filename(xy)),'r'); 

So every sample file gives me a ratio array, from which I want to plot the first column.

[Image Analyst]

What is filename_s?

[Tatjana Mü]

I changed filename(xy) from above into a string array, in which all filenames are saved. This filename should be part of the legend.

[Image Analyst]

Show that code.

[Tatjana Mü]

@Image Analyst

directory_name=uigetdir('','Ordner mit Messungen auswählen'); 
[nur_file_name,pfad]=uigetfile({'*.csv','csv-files (*.csv)';'*.*','all Files'},...
    'Die csv-Files der Proben oeffnen (probe_001.csv=',[directory_name '/'], 'Multiselect', 'on');
nur_file_name=cellstr(nur_file_name); 
nur_file_name=sort(nur_file_name);
filename=strcat(pfad,nur_file_name); 
anzahl_files=size(filename,2); 

for xy=1:anzahl_files
    fid_in=fopen(char(filename(xy)),'r'); 
    
%----------------Import element and intensities--------------------

clear element_RL 
clear intens_RL 

tmpImport = importdata(filename{xy},','); 
element_RL = tmpImport.colheaders;
 element_RL(:,[1 305])=[];
 element_RL=string(element_RL);
 [anzahl_zeile,anzahl_elemente]=size(element_RL);
 
 intens_RL=tmpImport.data;
 intens_RL(:,[1 305])=[];
 [anzahl_runs,anzahl_elemente]=size(intens_RL);

element_RL=regexprep(element_RL,'\[',''); 
element_RL=regexprep(element_RL,'\]',''); 
element_RL=regexprep(element_RL,'\''',''); 


%------------------Sr,Nd and Os save us column-----------------------

[~, PosSr87] = ismember('87Sr+', element_RL);
SpalteSr87(:,1)=intens_RL(:,PosSr87);
[~, PosSr86] = ismember('86Sr+', element_RL);
SpalteSr86(:,1)=intens_RL(:,PosSr86);
[~, PosNd143] = ismember('143Nd+', element_RL);
SpalteNd143(:,1)=intens_RL(:,PosNd143);
[~, PosNd144] = ismember('144Nd+', element_RL);
SpalteNd144(:,1)=intens_RL(:,PosNd144);
[~, PosOs187] = ismember('187Os+', element_RL);
SpalteOs187(:,1)=intens_RL(:,PosOs187);
[~, PosOs188] = ismember('188Os+', element_RL);
SpalteOs188(:,1)=intens_RL(:,PosOs188);

clearvars PosNd143 PosNd144 PosOs187 PosOs188 PosSr86 PosSr87


%---------------Calculation Average and Standarddeviation----------------

for k=1:anzahl_elemente
    Background(k)=mean(intens_RL(:,k)); 
    Sigma(k)=std(intens_RL(:,k)); 
end


%-----------------------Definition of limit------------------------------

SP_limit=Background+(4*Sigma);


%-----------------Define samples above limit and replace them---------------------

is_SP = intens_RL > SP_limit;
intens_RL(is_SP)=1;  
intens_RL(~is_SP)=0;  

intens_RL(:,all(intens_RL == 0))=[]; %delete columns with 0
intens_RL=intens_RL.';   
intens_RL(:,all(intens_RL == 0))=[]; 
intens_RL=intens_RL.';


%----------------------Calculation of limits-----------------------------

anzahl_runs1=size(intens_RL,1);
id = true(anzahl_runs1,1) ; 
for k=1:anzahl_runs1
    if any (intens_RL(k,:)==1)
        Ratio(k,1)=SpalteSr87(k,:)/SpalteSr86(k,:); 
        Ratio(k,2)=[[[SpalteNd143(k,:)/SpalteNd144(k,:)]/0.512638]-1]*10^4;
        Ratio(k,3)=SpalteNd143(k,:)/SpalteNd144(k,:);
        Ratio(k,4)=SpalteOs187(k,:)/SpalteOs188(k,:);      
        Ratio(isinf(Ratio))=0; 
        Ratio(isnan(Ratio))=0; 
        id(k) = 0 ; 
    end
 
end


%---------------------Save ratios in arrays-----------------------------

for k=1:4
    Mittelwert_RL(k)=mean(Ratio(:,k)); 
end

element_SI=["87Sr/86Sr","ENd(0)","Nd143/Nd144","Os187/Os188"];
anzahl_runs_RL=length(Ratio);
Ratio_RL=element_SI(1,:);
for j=1:anzahl_runs_RL
Ratio_RL(j+1,:)=Ratio(j,:);
end

Ratio_RL(1:2,5)=vertcat("Mittelwert 87Sr/86Sr",Mittelwert_RL(:,1));
Ratio_RL(1:2,6)=vertcat("Mittelwert ENd(0)",Mittelwert_RL(:,2));
Ratio_RL(1:2,7)=vertcat("Mittelwert Nd143/Nd144",Mittelwert_RL(:,3));
Ratio_RL(1:2,8)=vertcat("Mittelwert Os187/Os188",Mittelwert_RL(:,4));


%----------------------Plot of all samples--------------------------------

filename_s = matlab.lang.makeValidName(nur_file_name);
filename_s=string(nur_file_name);
filename_s = erase(filename_s,"_csv"); 
filename_s = erase(filename_s,"LiqQuant_");

%fn(xy)=filename_s(:,xy);

[NumRows1 NumCols1]=size(Ratio);
figure(1)
title('Proben 87Sr/86Sr');
xlabel('Partikel');
ylabel('87Sr/86Sr');
for p=1:anzahl_files
   h(p)= scatter(1:NumRows1, Ratio(:,1));
    legendtext{p} = filename_s(1,p);
    hold on
end
legend(h, legendtext)

end

[Walter Roberson]

Your plotting loop for p is inside your for xy loop so everything is getting plotted onto one figure. legends do not accumulate.

[Tatjana Mü]

@Walter Roberson what do you mean with legends do not accumulate? Is it not possible to use my filename as a legend?

[Image Analyst]

Your indenting is all messed up. Looks like you have a for loop with 5 other for loops inside of it. Is that what you want?

Type control-a (to select all) then control-i (to fix the indenting).

[Tatjana Mü]

@Image Analyst I am sorry for the messed up part. I am honestly kind of new in programming. I am mostly if it works like I want it to work. And mostly it just works like I want to have it, if I use a lot of loops.

Thank you for explaining the control a/ control i to me.

Do you maybe know why my legend is not working?