better method for evaluating matrix

1 view (last 30 days)
For given vector such as following, I want to make square matrix s such that
%constant, original form
N = 500;
x = 2*pi*linspace(0,1,N);
for i = 1:N
for j = 1:N
s(i,j) = sin(x(i)-x(j))
end
end
But it was too slow, so recently I edited it to following, but it's still too slow!!
Can anybody please help me??
%constant
N = 500;
x = 2*pi*linspace(0,1,N);
for i = 1: N;
s(:,i) = x-x(i);
end
s=sin(s);

Accepted Answer

Stephen23
Stephen23 on 21 Nov 2017
Edited: Stephen23 on 21 Nov 2017
You really need to learn how to write vectorized code. Solving every task using lots of ugly loops is not an efficient way to write MATLAB code. Try this:
N = 500;
vec = 2*pi*linspace(0,1,N);
mat = sin(bsxfun(@minus,vec(:),vec))

More Answers (1)

Andrei Bobrov
Andrei Bobrov on 21 Nov 2017
Edited: Andrei Bobrov on 21 Nov 2017
N = 500;
x = 2*pi*linspace(0,1,N);
s = sin(x(:)' - x(:));
for old versions of MATLAB:
s = sin( bsxfun(@minus, x(:)',x(:)) );
  1 Comment
Stephen23
Stephen23 on 21 Nov 2017
Edited: Stephen23 on 21 Nov 2017
Note that the output is transposed compared to the code given in the question.

Sign in to comment.

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!