Check Position with for loop, not enough input arguments

I made a simple function that loops between the rows and columns of an array using for loops. The loop is part of a function named checktakentest (Since I'm testing this method atm). I keep getting the error that there aren't enough input arguments.
function [spotTaken] = checktakentest(tttArray)
for h = 1:3
if tttArray(h,j) == 1
%Is spot is taken, break loop
spotTaken = 1; break;
else
spotTaken = 0;
end
for j=1:3
if tttArray(h,j) == 1
spotTaken = 1; break;
else
spotTaken = 0;
end
end
end
I tried also defining h and j previously as follows
h = [1,2,3];
j = [1,2,3];
Note that tttArray is a global variable defined in another function and its array values change in that function. A spot taken is 1, empty is 0. What arguments should I pass to the function and how do I know which ones to pass since this has been a recurring problem for me? A simple explanation would be appreciated. Note that I call the function via
checktakentest(tttArray)

3 Comments

Need to see the calling sequence and error in context to tell, but...
  1. As you show it, you've thrown away the result of the routine so there wasn't any point in calling it to begin with-- use a return variable, and
  2. Do NOT use a global array for the data array; instead compute it wherever it is it needs be but again use an array in which to return its new value (can be the same as that with which you call it) and pass that to any other function(s) that need it.
  3. As you've written it, j is undefined in the first loop; variables are local within the scope of functions excepting for (ugly!) global ones which are as noted to be avoided if at all possible. Hence, defining the loop variable outside the function has no bearing; those h, j are entirely different variables than those using the same names inside the function. Besides, when you create the for loop, even if they were in the function they're being re-defined.
It's not clear what you want the function to return, an array or a single value for a given location as true/false. If the latter, may as well just test the location in the calling function; that's all it is. If a logical array for the input array, then no loops are needed, simply
isTaken=(tttArray==1); % logical array, T if position set
So I want to test if the location is taken (1) or not (0), how would I do that with the logical array as you stated without loops?
isTakenIJ=(tttArray(i,j)==1); % test single element
Since you're keeping just 0/1 values, even though it's not a logical array you can simply use
isTakenIJ=(tttArray(i,j)==1); % test single element
Again, precisely what might work best depends on what you're really after in the calling routine; you've got an array that contains 0|1 and you're creating another either array or single value that's also 0|1 in the same location(s). That seems at least somewhat redundant... :)

Sign in to comment.

More Answers (1)

checktakentest = @(x)any(x(:) == 1);
spotTaken = checktakentest(tttArray);

Categories

Find more on Loops and Conditional Statements in Help Center and File Exchange

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!