How can I draw smithchart ? I'm gettting an error
Show older comments
How can I draw smithchart ? I'm gettting an error
6 Comments
Walter Roberson
on 5 May 2018
In the line
Smith_plotYL(ax,YL,1/z0)
z0 does not exist but Z0 does.
I do not find any Smith_plotYL anywhere on the Internet ? You appear to be using an unknown software package.
John BG
on 5 May 2018
z0 should be Z0
My contribution was uploaded in April 2017 and it's still available to any interested reader:
I wrote the lines that good Ali Osman is asking about that were uploaded in April 2017 in PDF format, have a look
document attached too.
Jan please remove the false comments from this question.
My comments were correct, when I've posted them, and they still do not contain wrong details.
The copyright infringement concerned the attached file "support_functions01.zip", from which I have removed "intersections.m". This function has been removed from John BG's answer answer_245599 already.
John BG
on 21 May 2018
ok, the missing license file for the support function has updated. The problem you refer to is over. Now please remove the misleading comments you have scattered in this question.
John BG
on 21 May 2018
and please stop editing the comments written by others. Just add your comments appended to anything you object, but by editing others comments you cause further confusion.
Answers (1)
Hello Ali
You are using some of the functions I have written to help develop MATLAB code for Smith chart related tasks.
I posted the code the Ali Osman is reproducing in his question 1 year ago, available here:
returns solutions that include such functions, haven't compiled them yet into a single toolbox, and I don't think I am going to, because MATLAB already has an RF toolbox.
1.
your line
Smith_plotYL(ax,YL,1/Z0)
should be
Smith_plotY(ax,YL,1/Z0)
2.
your line
gb1_xint(1)+1j*yint(1);
should be
gb1=xint(1)+1j*yint(1)
3.-
Please find attached the support functions needed to have your script working.
4.
your line
plot(ax,real(gamma),imag(gamma),'r0','LineWidth',1.5); %çizim
should be
plot(ax,real(gamma),imag(gamma),'ro','LineWidth',1.5); %çizim
5.-
the result
is similar to those obtained with
Ali, please download again from the above link because I have fixed a couple syntax errors that may have induced your question regarding my code.
Ali Osman
if you find this answer useful would you please be so kind to consider marking my answer as Accepted Answer?
To any other reader, if you find this answer useful please consider clicking on the thumbs-up vote link
thanks in advance for time and attention
John BG
18 Comments
Walter Roberson
on 5 May 2018
Thanks, John.
This answer contained copy-righted code taken from https://www.mathworks.com/matlabcentral/fileexchange/11837-fast-and-robust-curve-intersections?focused=7711886 without mentioning the author.
No problem, here you have the reference:
the support function combinator.m attached to the support functions is an earlier version of https://uk.mathworks.com/matlabcentral/fileexchange/24325-combinator-combinations-and-permutations?s_tid=srchtitle
Since I don't know if it's the same function, to avoid people looking for an earlier version in case there's a compatibility issue, I attach it to help readers.
Jan, rest assured that no one is attempting to breach any IP, or claim authorship of such wonderful function.
I downloaded years ago, and even the author used a different Mathworks forum name.
Jan, by the way, you have recently written a similar function, haven't you?
if you let me know where can I download your version of Matt's combinator I will have a look and check whether it all works with your combinator instead of Matt Fig's , ok?
Regards
John BG
The rules are easy and have been explained repeatedly: Code published in the FileExchange is covered by the BSD license and must be accompanied by the license text, which includes the name of the author. To be exact: The 2-clause Simplified BSD License.
Code posted in the forum is covered by the Creative Commons Attribution Share Alike 3.0 license, CC BY-SA 3.0.
The safe way is to post links to FileExchange submissions instead of the code.
combinator did not appear in this thread.
combinator.m is part of the answer, it happens all the time: people supplying solutions that use some one else's functions, available in the Mathworks File Exchange, or else where.
I have already clearly mentioned the author.
So, for all the readers to understand the point that you are trying to make, what would be the file that has to be attached to an answer using a support function from some one else?
Osman is copying the lines of one of my File Exchange contributions and I don't consider Osman infringing any Intellectual Property regulation.
Jan
on 12 May 2018
@John BG: "combinator.m is part of the answer" - This command does not occur anywhere in the question or answer. It was not included in the ZIP file also, but Douglas Schwarz' intersections.m was.
"what would be the file that has to be attached to an answer using a support function from some one else" - Open FEX: robust-curve-intersections. Click on the "View License" link on the top right. You see:
----------------------------------------------------------------
Copyright (c) 2017, Douglas M. Schwarz All rights reserved.
Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
- Redistributions of source code must retain the above copyrightnotice, this list of conditions and the following disclaimer.
- Redistributions in binary form must reproduce the above copyrightnotice, this list of conditions and the following disclaimer inthe documentation and/or other materials provided with the distribution
[AND THE DISCLAIMER...]
----------------------------------------------------------------
"I have already clearly mentioned the author." - No you didn't mention Douglas Schwarz anywhere. But even if you did, you are obliges by the license to do something else: ...must retain the above copyright notice, this list of conditions and the following disclaimer.
This license file is contained also in all ZIP files you can download from the FileExchange, or it is attached to the code as comment.
You have posted code of Matlab's toolbox functions and FEX submissions repeatedly. See this thread for clear and unequivocal instructions: https://www.mathworks.com/matlabcentral/answers/322209-is-it-legal-to-publish-the-source-code-of-matlab-s-toolbox-functions .
What about me? I also deserve some credit, oder?
after all I wrote the code that Osman is copying in his question.
So, Jan Simon: why haven't you told Osman he should have mentioned me as the author of the code he has reproduced in his question in first place?
John BG
on 12 May 2018
In any case, I fixed the errors that Osman asked for.
A satisfactory answer with working code has supplied by me.
If Osman decides to remain silent regarding who deserves this accepted answer, I ask for any advance MATLAB forum user to consider marking my answer as the accepted answer to this question.
This or contact Osman and ask to decide,
Walter Roberson
on 12 May 2018
"after all I wrote the code that Osman is copying in his question."
Citation?
I see some lines that are the same as https://www.mathworks.com/matlabcentral/answers/310051-how-to-plot-smith-chart#answer_245599 but most of the code the user posted is different.
I see that the user has used routines that you have written, but the user does not appear to have posted the source code for any of them.
Jan
on 13 May 2018
@John BG: Code, which is posted without considering the required license conditions, is removed from the forum. As long as you ignore this trivial fact penetratingly, you waste the time of the editors. This affects my opinion about what you deserve.
I do not see an evidence for your claim, that you are the author of the code posted by Ali Osman Aydin.
Jan Simon, perhaps you should try to download what Ali Osman downloaded to ask the question, so you really understand the question.
try it now, easy, just click on the following link:
1 year ago I wrote and posted in the File Exchange exactly the lines that Ali Osman uses.
If you open the attached PDF file you will be able to read in blue font the code I refer.
The question refers to Smith Chart support functions I wrote 1 year ago too, that I have now included in the download that Ali Osman is asking about.
You were right that I had not included D Schwarz license file, but I made it clear where could that support function be downloaded from.
Now I have included all required license files in the same pack too.
Would you please be so kind to check it now?
If you don't say anything I will understand that you accept the packed files, with all the relevant licenses, as it has been just updated today, and therefore there shouldn't be any need for remarks like the last one above, that I find pointless and rude.
Again I consider I deserve this accepted answer.
John BG
Walter Roberson
on 16 May 2018
John, you are correct, the original poster was quoting you without having posted the appropriate license. I have removed their posted code for copyright violation.
Walter Roberson
on 16 May 2018
"If Osman decides to remain silent regarding who deserves this accepted answer, I ask for any advance MATLAB forum user to consider marking my answer as the accepted answer to this question."
John BG: in the past you have made it clear that you wish the original poster to decide what is accepted, not the high privilege users, so we must decline to Accept the Answer on behalf of the poster. If the poster wishes to Accept the Answer then they will.
Walter, thanks for your attention on this QA, but I did really post line by line the code that Ali uses in his question.
I uploaded it in a .PDF file, without the .m file.
Ali copied line by line, but I did not include any support function. Even you asked what were those functions.
My error, now fixed.
Anyone can download all files for my earlier FEX in a single .zip here:
Ali Osman is not taking further action, in my opinion because of the negative comments added by Jan (Simon). All the noise with the lincese files may have induced Ali to think that if he admits he is reproducing code there may be some hidden fee.
To ALI OSMAN: YOU CAN REPRODUCE ANY CODE YOU FIND IN THIS FORUM WITHOUT ANY KIND OF MONEY LEVY, OR FEE, OR ROYALTY whatsoever. The only thing is that forum rules want the original author to be mentioned in any code reproduction.
I couldn't agree more.
Walter Roberson
on 16 May 2018
"I did really post line by line the code that Ali uses in his question"
Indeed, with the reference you gave I was able to see that, and I removed the code, which should not have been posted without a license.
"The only thing is that forum rules want the original author to be mentioned in any code reproduction."
Not exactly. The license for material in the File Exchange requires that the license file be posted if code from one of the contributions is quoted beyond fair use. The license for postings in MATLAB Answers is a bit different. But both licenses allow reproduction without charge provided the copyright terms are adhered to.
@John BG: "You were right that I had not include D Schwarz license file, but I made it clear where could that support function be downloaded from." - No, you didn't. It was me who has posted the name of the author and the link. Afterwards you mentioned combinator written by someone else.
"The only thing is that forum rules want the original author to be mentioned in any code reproduction." - Insisting on this wrong claim does not make it more true. See above comment.
The admins and editors have removed copy-righted code repeatedly from your contributions. Follow the rules, and such "noise" as in this discussion will not happen.
John BG
on 19 May 2018
Walter
this is another contribution of mine, related to Smith chart plotting. Please have a look at the comment I have added right under the question.
I am giving Jan Simon the benefit of the doubt, so I assume he simply did not open the PDF that show the code I uploaded in April 2017.
I have corrected the support function license issue.
All this copyright fuss draws the attention away from the fact that I solved the errors that Ali Osman asked about.
I answered this question from Ali Osman, I politely ask Ali Osman or any forum power user to help me leave these QA as a simple query, removing all misleading comments, most of them from Jan (Simon).
I am going to reword it again, this question from Ali Osman has been solved with my contribution.
And so far, no one else has added any answer solving the question.
Walter Roberson
on 19 May 2018
John BG: you edited the citation of your contribution into place after Jan said that he did not see any evidence that you were the author of the code that was originally posted. I had also asked for evidence as I had actively googled a number of different lines of the code and found matches for only the first three lines. I had no evidence at the time. Jan had no evidence at the time. His remarks were correct and were not misleading.
Since the time you posted the link to your contribution, I have not seen anyone questioning that you did in fact contribute the code that the user originally posted.
The matter after that time has been about whether the Answer you originally posted here cited copyright work properly. You have edited in a citation, but that does not make it misleading that Jan has not removed the remarks pointing out that you originally had difficulty in that manner.
I thanked you for your response and I voted for your Answer, as you made useful contributions to the user. But I am not going to remove Jan's remarks as they were not misleading at the time they were made. The authorized editors enforce the copyright policy on everyone, not just on you.
I am not going to Accept on behalf of the user as you have made your opposition to that clear in the past. If you grant the power users authority to Accept on behalf of the users then you also grant them authority to make decisions about which Answer is best, potentially Accepting someone else's Answer in cases where you have posted an Answer. You have firmly indicated in the past that you believe that it should be strictly up to the user to choose the Answer that the user prefers. Accordingly, if the user prefers not to Accept an Answer of your creation that looks to be well considered, I have to defer to your strongly expressed opinions of the past and refrain from Accepting on behalf of the user.
Categories
Find more on Downloads in Help Center and File Exchange
on 4 May 2018
on 21 May 2018
Community Treasure Hunt
Find the treasures in MATLAB Central and discover how the community can help you!
Start Hunting!
